fix(error): More closely match rustc's error style #4602

epage · 2023-01-03T19:29:14Z

This is a follow up to #4385.

For example, rustc provides this error:

error[E0425]: cannot find value `arg1` in this scope
    --> src/builder/command.rs:4249:23
     |
4249 |                 arg = arg1.help("Print help");
     |                       ^^^^ help: a local variable with a similar name exists: `arg`

For more information about this error, try `rustc --explain E0425`.
error: could not compile `clap` due to previous error

So with both PRs, we went from

error: Found argument '--unknown' which wasn't expected, or isn't valid in this context

  If you tried to supply '--unknown' as a value rather than a flag, use '-- --unknown'

Usage: interop_hand_subcommand[EXE] add [NAME]...

For more information try '--help'

to

error: found argument '--unknown' which wasn't expected, or isn't valid in this context

  note: to pass '--unknown' as a value, use '-- --unknown'

Usage: interop_hand_subcommand[EXE] add [NAME]...

For more information, try '--help'.

This matches the rustc error style

clap-rs/clap#4602 changed the start of the error messages to lower case. Since the change is trivial, I included this into the same PR. Ref.: clap-rs/clap#4602

epage added 2 commits January 3, 2023 13:17

fix(error): Lowercase the start of error messages

c2efb60

This matches the rustc error style

fix(error): Match rustc for giving more information

68a7740

epage merged commit 689c77a into clap-rs:master Jan 3, 2023

epage deleted the errors2 branch January 3, 2023 19:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(error): More closely match rustc's error style #4602

fix(error): More closely match rustc's error style #4602

epage commented Jan 3, 2023

fix(error): More closely match rustc's error style #4602

fix(error): More closely match rustc's error style #4602

Conversation

epage commented Jan 3, 2023